Skip to content

Avoid failure when only some passed easyconfigs exist#4847

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:same-file-fix
Apr 9, 2025
Merged

Avoid failure when only some passed easyconfigs exist#4847
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:same-file-fix

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

When processing multiple EasyConfigs where one does not exist samefile will abort with a FileNotFoundError.
So move the existance check to the top of the loop.

When processing multiple EasyConfigs where one does not exist `samefile`
will abort with a `FileNotFoundError`.
So move the existance check to the top of the loop.
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Apr 9, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 9, 2025
@boegel boegel merged commit 3ff6130 into easybuilders:develop Apr 9, 2025
37 checks passed
@Flamefire Flamefire deleted the same-file-fix branch April 9, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants