Skip to content

Enhance RPATH sanity check to skip anything whose absolute path resolves to outside the install dir#4854

Merged
lexming merged 4 commits intoeasybuilders:developfrom
jfgrimm:rpath-sanity-resolve-path
Apr 24, 2025
Merged

Enhance RPATH sanity check to skip anything whose absolute path resolves to outside the install dir#4854
lexming merged 4 commits intoeasybuilders:developfrom
jfgrimm:rpath-sanity-resolve-path

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Apr 23, 2025

this should solve issues of the kind seen in: easybuilders/easybuild-easyconfigs#22789

resolves to outside of the installation directory
Comment thread easybuild/framework/easyblock.py Outdated
Comment thread easybuild/framework/easyblock.py Outdated
@jfgrimm jfgrimm requested a review from lexming April 23, 2025 10:35
@boegel boegel added this to the 5.0.1 milestone Apr 23, 2025
boegel
boegel previously requested changes Apr 23, 2025
Comment thread easybuild/framework/easyblock.py Outdated
@boegel boegel changed the title Enhance rpath sanity check to skip anything whose absolute path resolves to outside the install dir Enhance RPATH sanity check to skip anything whose absolute path resolves to outside the install dir Apr 23, 2025
@jfgrimm jfgrimm requested a review from boegel April 23, 2025 12:24
Add resolved and install dir paths to log message
@jfgrimm jfgrimm force-pushed the rpath-sanity-resolve-path branch from db089ed to 2e939a6 Compare April 23, 2025 12:37
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming dismissed boegel’s stale review April 24, 2025 15:25

review addressed by author

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Apr 24, 2025

Merging, thanks @jfgrimm !

@lexming lexming merged commit 354d0b6 into easybuilders:develop Apr 24, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants