Skip to content

print summary after the build in trace output#4861

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
smoors:summary
Apr 30, 2025
Merged

print summary after the build in trace output#4861
branfosj merged 1 commit intoeasybuilders:developfrom
smoors:summary

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Apr 26, 2025

examples:

first build failed:

== Summary:
   * [F] Kaleido/0.2.1-GCCcore-13.3.0
   * [-] MultiQC/1.28-foss-2024a

the first build succeeded, the second failed:

== Summary:
   * [S] Kaleido/0.2.1-GCCcore-13.3.0
   * [F] MultiQC/1.28-foss-2024a

both builds succeeded:

== Summary:
   * [S] Kaleido/0.2.1-GCCcore-13.3.0
   * [S] MultiQC/1.28-foss-2024a

Note

with rich, in some cases a summary line like this is printed, showing the installed modules:

0:01:08  1 out of 2 easyconfigs done: Kaleido/0.2.1-GCCcore-13.3.0 (OK)

however, that is not sufficient:

  • it is not printed if all builds succeeded
  • it is not printed if you don’t have rich installed (or if you specified a different output style)
  • it doesn’t show the module that failed and the ones that didn’t build

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Apr 28, 2025 •
edited
Loading

would be nice to add coloring to the trace output, but we can do that in another PR

@branfosj branfosj added this to the release after 5.0.1 milestone Apr 30, 2025
@branfosj branfosj merged commit 79e458a into easybuilders:develop Apr 30, 2025
37 checks passed
@branfosj branfosj modified the milestones: release after 5.0.1, 5.0.1 Apr 30, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented May 7, 2025 •
edited
Loading

@smoors Shouldn't we also include a legend, to indicate what each of the letters mean?

So rather than this:

== Build succeeded for 3 out of 3
== Summary:
   * [S] M4/1.4.19-GCCcore-12.2.0
   * [F] Bison/3.8.2-GCCcore-12.2.0
   * [-] flex/2.6.4-GCCcore-12.2.0

We can print:

== Summary ([-]: skipped, [F]: failed, [S]: success)
   * [S] M4/1.4.19-GCCcore-12.2.0
   * [F] Bison/3.8.2-GCCcore-12.2.0
   * [-] flex/2.6.4-GCCcore-12.2.0

@branfosj branfosj mentioned this pull request May 8, 2025
Closed
@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 8, 2025

@boegel see #4872

@smoors smoors mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@smoors @boegel @branfosj