also ignore errors raised during test step when --ignore-test-failure is used#4881
Merged
lexming merged 3 commits intoeasybuilders:developfrom May 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in EasyBuild v5.0.0, see the changes that were made in
EasyBlock._test_stepin:run_shell_cmdin easyblock.py (+ use f-strings) #4383While
--ignore-test-failureworked with EasyBuild 4.x to let an installation of PyTorch complete even when too many failing tests were found, it doesn't work anymore with EasyBuild v5.0.0 because the custom easyblock for PyTorch raises anEasyBuildError(since it goes way beyond just a running a shell command in the test step).test_toy_failing_test_stepwas enhanced to verify the fix