Fix reporting of method name in EasyBlock.run_step#4920
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jun 18, 2025
Merged
Fix reporting of method name in EasyBlock.run_step#4920boegel merged 1 commit intoeasybuilders:developfrom
EasyBlock.run_step#4920boegel merged 1 commit intoeasybuilders:developfrom
Conversation
The step method is a method returning the actual method. The `Bundle` easyblock uses a `getattr` call there instead of the method name. As the reflection looks at local name(s) it will find the `getattr` instead of the actual method. Access the `__name__` property of the returned function instead so we will always get the right name no matter how the lambda/method is defined.
d3dadd4 to
f979cad
Compare
EasyBlock.run_step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step method is a method returning the actual method. The
Bundleeasyblock uses agetattrcall there instead of the method name.As the reflection looks at local name(s) it will find the
getattrinstead of the actual method.Access the
__name__property of the returned function instead so we will always get the right name no matter how the lambda/method is defined.