Keep symlinks when copying build dirs of failed installations#4933
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jul 3, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)Especially TensorFlow and PyTorch heavily use symlinks in the build folder (e.g. Bazel creates "virtual dirs" to recreate fixed folder structures).
For PyTorch this just failed for me due to recursive symlinks (couldn't check which one).
I don't see a reason to resolve symlinks which results in at least more space used and such failures as above at worst, so let's just keep the symlinks which also more closely resembles the build dir.