also copy patches of extensions to easybuild subdirectory of installation directory#4939
Conversation
|
I was going to say we also need to check for patches of components, but I see this is actually solved in the easyblock in that case. However, that solution can be problematic as the patch then has to appear in the parent bundle directory and in a directory for the individual component (see easybuilders/easybuild-easyconfigs@6afd169 for an example) |
…ld' subdir in installation directory
Good catch! I've done the same for the code that copies the patches to a central repo.
So you want to copy them to both directories? It is currently rather confusing which file ends up where, and it's going to duplicate some things, so shouldn't we first decide on a proper structure for this |
Not going to delay this to figure that out. IMO the correct place is the |
enhance test to verify that extension patches were copied to 'easybuild' subdir in installation directory
|
Note that this bug fix introduced a new bug that pops up when installing an easyconfig with an extension that has a patch. See #4959 (comment) for more details, and a fix is implemented in #4960. |
Solves #4864 by adding the patches of extensions to the list of patches that are copied to
$installdir/easybuild.Note that there's also #4863: I'm not sure if the patches should go into either
easybuildoreasybuild/reprodor both, for now I've taken the same approach that is used for regular patches: only copy them toeasybuild. But this can be easily changed.