retry fetching source file for extensions from PyPI with alternative filename (with - replaced with _ in extension name)#4943
Merged
jfgrimm merged 3 commits intoeasybuilders:developfrom Nov 27, 2025
Conversation
Flamefire
reviewed
Jun 30, 2025
Contributor
Couldn't there be packages like |
Contributor
Author
yes, we should keep the spelling of PyPI for the extension |
download_filename
download_filename- replaced with _)
- replaced with _)- replaced with _ in extension name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if downloading an extension fails, retry by replacing hyphen with underscore in the name:
abc-def-%(version).tar.gz->abc_def-%(version).tar.gzonly done if:
sourcesorsource_tmplspecified)when this is merged, i would recommend to always use the exact name of the package listed on PyPI as the extension name:
module spider <package>module spider), avoiding that the same package is available with 2 different names, and thus easier to find all installed versions.at some point we might consider switching to the underscore for the tarball on the first try, as that is the recommended name format, see
https://packaging.python.org/en/latest/specifications/source-distribution-format/#source-distribution-file-name