Skip to content

Handle post_install_patches and post_install_msgs for extensions#4980

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:postinstallpatch-extensions
Aug 27, 2025
Merged

Handle post_install_patches and post_install_msgs for extensions#4980
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:postinstallpatch-extensions

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Those EasyConfig parameters were silently ignored. Run the appropriate steps in the default implementation of post_install_extension similar to postinstall_cmds and add a test. Using the new name for post_install_patches in the test reveals the need to handle that explicitely as a raw dict is used.

Those EasyConfig parameters were silently ignored.
Run the appropriate steps in the default implementation of
`post_install_extension` similar to postinstall_cmds and add a test.
Using the new name for `post_install_patches` in the test reveals the need
to handle that explicitely as a raw dict is used.
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Handle post_install_patches and post_install_msgs for extensions Handle post_install_patches and post_install_msgs for extensions Aug 27, 2025
@boegel boegel added this to the next release (5.1.2) milestone Aug 27, 2025
@boegel boegel merged commit 1b916db into easybuilders:develop Aug 27, 2025
37 checks passed
@Flamefire Flamefire deleted the postinstallpatch-extensions branch August 27, 2025 14:01
@Flamefire
Copy link
Copy Markdown
Contributor Author

Followup for GH integration: #5016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants