update regex used in Lmod.get_setenv_value_from_modulefile#4998
Merged
branfosj merged 2 commits intoeasybuilders:developfrom Sep 13, 2025
Merged
update regex used in Lmod.get_setenv_value_from_modulefile#4998branfosj merged 2 commits intoeasybuilders:developfrom
Lmod.get_setenv_value_from_modulefile#4998branfosj merged 2 commits intoeasybuilders:developfrom
Conversation
…to account 'setenv{...}' rather than 'setenv(...)' produced by 'module show' with Lmod 8.7.60+
branfosj
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update regex used in
Lmod.get_setenv_value_from_modulefileto take into accountsetenv{...}rather thansetenv(...)produced bymodule showwith Lmod 8.7.60+ (for module files in Tcl syntax)See also TACC/Lmod#792
I don't think it hurts to make the regex just a little bit more liberal, especially since there's a range of Lmod versions (incl. the most recent versions currently) that produce slightly different
showoutput...Hat tip to @xdelaruelle who reported that the
test_external_dependenciestest was failing when using latest Lmod version