Skip to content

update build_and_install_one function to take into account that application log file may not exists#5004

Merged
bedroge merged 1 commit intoeasybuilders:developfrom
boegel:fix_from_pr_x
Sep 24, 2025
Merged

update build_and_install_one function to take into account that application log file may not exists#5004
bedroge merged 1 commit intoeasybuilders:developfrom
boegel:fix_from_pr_x

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 24, 2025

This fixes a regression that was introduced in:

The application_log = app.logfile change that was made there implicitly assumes that app.logfile is always a path to an existing file, but that's not necessarily the case, for example when eb --extended-dry-run or eb -x is used.

This bug was caught by test_github_from_pr_x, which fails as follows currently in develop:

ERROR: test_github_from_pr_x (test.framework.options.CommandLineOptionsTest)
Test combination of --from-pr with --extended-dry-run.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/easybuild-framework/test/framework/options.py", line 2211, in test_github_from_pr_x
    self.eb_main(args, do_build=True, raise_error=True, testing=False)
  File "/tmp/easybuild-framework/test/framework/utilities.py", line 352, in eb_main
    raise myerr
  File "/tmp/easybuild-framework/test/framework/utilities.py", line 325, in eb_main
    main(args=main_args, logfile=logfile, do_build=do_build, testing=testing, modtool=modtool)
  File "/tmp/easybuild-framework/easybuild/main.py", line 774, in main
    do_cleanup = process_eb_args(orig_paths, eb_go, cfg_settings, modtool, testing, init_session_state,
  File "/tmp/easybuild-framework/easybuild/main.py", line 593, in process_eb_args
    ecs_with_res = build_and_install_software(
  File "/tmp/easybuild-framework/easybuild/main.py", line 191, in build_and_install_software
    if os.stat(parent_dir).st_mode & 0o200:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/eb-be7trg__/eb-tlnxxs7u/eb-prc3a4a3/eb-vmvw1t3n'

This didn't surface in PRs because this test requires a GitHub token, so it's only actually run after a PR is merged, or when a branch is pushed to a fork where a GitHub token is available as a "secret".

@boegel boegel added this to the next release (5.1.2) milestone Sep 24, 2025
@boegel boegel added the bug fix label Sep 24, 2025
bedroge
bedroge approved these changes Sep 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge bedroge enabled auto-merge September 24, 2025 18:26
@bedroge bedroge merged commit 04af52f into easybuilders:develop Sep 24, 2025
37 checks passed
@boegel boegel deleted the fix_from_pr_x branch September 24, 2025 19:07
This was referenced Sep 24, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedroge bedroge bedroge approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @bedroge