Skip to content

Added command line parameter --fetch-all#5014

Merged
boegel merged 19 commits intoeasybuilders:developfrom
Rommelse:develop
Apr 7, 2026
Merged

Added command line parameter --fetch-all#5014
boegel merged 19 commits intoeasybuilders:developfrom
Rommelse:develop

Conversation

@Rommelse
Copy link
Copy Markdown
Contributor

@Rommelse Rommelse commented Oct 4, 2025

Added command line parameter --fetch-all. It implies --fetch. But when a fetch fails, EasyBuild will still try to fetch all dependencies. This is handy in situations where the success of fetching is non-deterministic and the engineer wants to get all failures at once without having to restart after each failure. Non-deterministic success of fetching can for example happen if some downloads are intercepted by the CyberDefence team to scan for vulnerabilities and later retries are handled by earlier scans that have been cached.

Rommelse and others added 10 commits October 4, 2025 13:23
…t when a fetch fails, EasyBuild will still try to fetch all dependencies. This is handy in situations where the success of fetching is non-deterministic, and the engineer wants to get all the failures at once without having to restart after each failure. Non-deterministic success of fetching can for example happen if some downloads are intercepted by the CyberDefence team to scan for vulnerabilities, and later retries are quickly handled by earlier scans that have been cached.
@boegel boegel changed the title Added command line parameter --fetch-continue Added command line parameter --fetch-continue Oct 8, 2025
@boegel boegel added this to the next release (5.2.0?) milestone Oct 8, 2025
Comment thread easybuild/tools/options.py Outdated
Comment thread easybuild/framework/easyblock.py Outdated
@Rommelse Rommelse changed the title Added command line parameter --fetch-continue Added command line parameter --fetch-all Dec 7, 2025
@Rommelse Rommelse requested a review from boegel December 7, 2025 21:23
@boegel boegel modified the milestones: next release (5.2.1), 5.x Feb 11, 2026
@Rommelse
Copy link
Copy Markdown
Contributor Author

Hi @boegel . Quite a while ago, I implemented the suggestions that came from your review. But then I might have forgotten to click the "Resolved" button in the PR in the webui. I see the milestone gets keeping postponed from 5.2.0 to 5.2.1 to 5.x.
Is that because I forgot the "Resolved" button? Or is there another reason?

I clicked the Resolved button today. I first sync-ed the latest changes from the develop branch into this PR branch. I tested the new "--fetch-all" option again. Still work as expected, especially also in combi with --downoad-timeout.

Is there anything more I can do from my side to get this PR merged onto the develop branch?

@boegel boegel modified the milestones: 5.x, next release (5.2.2?) Feb 25, 2026
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2026

Hi @boegel . Quite a while ago, I implemented the suggestions that came from your review. But then I might have forgotten to click the "Resolved" button in the PR in the webui. I see the milestone gets keeping postponed from 5.2.0 to 5.2.1 to 5.x. Is that because I forgot the "Resolved" button? Or is there another reason?

I clicked the Resolved button today. I first sync-ed the latest changes from the develop branch into this PR branch. I tested the new "--fetch-all" option again. Still work as expected, especially also in combi with --downoad-timeout.

Is there anything more I can do from my side to get this PR merged onto the develop branch?

@Rommelse I think this mostly went "out of view", I'll try and take another look at it and see if we can get it merged...

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit f01e237 into easybuilders:develop Apr 7, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants