Skip to content

Allow the use of extension specific github_account so GITHUB_SOURCE template constant can be used#5121

Merged
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:allow_ext_specific_github_account
Mar 24, 2026
Merged

Allow the use of extension specific github_account so GITHUB_SOURCE template constant can be used#5121
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:allow_ext_specific_github_account

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

Makes it possible to use templates like GITHUB_SOURCE in source_urls in extensions

Makes it possible to use templates like GITHUB_SOURCE in source_urls in extensions
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 9, 2026

@akesandgren Are you sure this is sufficient?

@akesandgren
Copy link
Copy Markdown
Contributor Author

Well, it works when I use it. I've only tested having github_account inside an extension, not in ext_options but it should pick it up from there too due to the code that handles ext_options and extensions.

@boegel boegel changed the title Allow the use of extension specific github_account Allow the use of extension specific github_account so GITHUB_SOURCE template constant can be used Mar 24, 2026
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 241faa8 into easybuilders:develop Mar 24, 2026
40 checks passed
@akesandgren akesandgren deleted the allow_ext_specific_github_account branch March 25, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants