enhance get_cuda_object_dump_raw to not run cuobjdump on shell scripts to determine CUDA architecture#5161
Merged
boegel merged 2 commits intoeasybuilders:developfrom Apr 8, 2026
Merged
Conversation
Before checking a file for CUDA code a `file` command is used and the output search for "executable", which wrongly triggers for Python, Bash, ... scripts Exclude those to avoid uneccessary commands and errors logged.
195b5bf to
bc9d23d
Compare
Member
|
@Flamefire Do you have a concrete example of what this avoids/fixes, just for context? |
get_cuda_object_dump_raw to not run cuobjdump on shell scripts to determine CUDA architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before checking a file for CUDA code a
filecommand is used and theoutput search for "executable", which wrongly triggers for Python, Bash, ... scripts
Exclude those to avoid unnecessary commands and errors logged.