Skip to content

set group id early on, and make eb aware of consistent chmod/chown failures#527

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:chgrp_fail
Mar 22, 2013
Merged

set group id early on, and make eb aware of consistent chmod/chown failures#527
boegel merged 6 commits intoeasybuilders:developfrom
boegel:chgrp_fail

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 8, 2013

No description provided.

Comment thread easybuild/tools/filetools.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean %.0f instead of this %d / int

Conflicts:
	easybuild/tools/filetools.py

also fixed remarks along the way
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 22, 2013

Addressed remarks, synced with develop.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 22, 2013

@stdweird: Let me know if you think this is good to go...

Comment thread easybuild/tools/filetools.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel log and _log ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict resolution fail, nice catch. Fixed.

@stdweird
Copy link
Copy Markdown
Contributor

ok, it's better like that. just one tiny issue i think

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 22, 2013

Remarks resolved, unit tests pass => merging it in!

boegel added a commit that referenced this pull request Mar 22, 2013
set group id early on, and make eb aware of consistent chmod/chown failures
@boegel boegel merged commit 6c82265 into easybuilders:develop Mar 22, 2013
@boegel boegel deleted the chgrp_fail branch March 22, 2013 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants