deal with legacy usage of license parameter#569
Merged
boegel merged 2 commits intoeasybuilders:developfrom Mar 27, 2013
Merged
Conversation
Member
There was a problem hiding this comment.
No need to return extra_options, since you're passing a dict (pointer) as argument? Can't hurt though...
Member
|
Not 100% sure I fully grasp the code, but I see the intention/goal. Just take a look at the minor remark, but should be good to merge imho. |
Contributor
Author
|
@boegel fixed remark |
boegel
added a commit
that referenced
this pull request
Mar 27, 2013
deal with legacy usage of license parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.