make BLACS optional as toolchain element, depending on ScaLAPACK version#638
Merged
boegel merged 4 commits intoeasybuilders:developfrom May 27, 2013
Merged
make BLACS optional as toolchain element, depending on ScaLAPACK version#638boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
…vs toolchain module; this allows to make BLACS optional
…not (required to filter out LIBBLACS)
… with ScaLAPACK 2.x, only set BLACS variables if required
…directly; don't set BLACS variables empty, Blacs support takes care of proper handling of that
Contributor
There was a problem hiding this comment.
this should be generalised so it is called everywhere in a similar matter
Member
Author
There was a problem hiding this comment.
I'm not sure what you mean here... is_required has a default return True definition in toolchain.py, so it can be called from everywhere?
Contributor
There was a problem hiding this comment.
after discussing with @boegel it seems i misunderstod something.
ignore this remark
Contributor
|
@boegel looks fine, by the is_required call should be generalised to all (sub)toolchains. |
boegel
added a commit
that referenced
this pull request
May 27, 2013
make BLACS optional as toolchain element, depending on ScaLAPACK version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to support both iqacml 3.x and 4.x, for example (see easybuilders/easybuild-easyconfigs#267)