fix 'eb --list-toolchains'#675
Merged
boegel merged 5 commits intoeasybuilders:developfrom Aug 29, 2013
Merged
Conversation
…tions unit tests first
…nst uninitialized config (fixes easybuilders#674)
Contributor
There was a problem hiding this comment.
except for a doubly nested for on the above docstring (!), it all looks good to me;
i'm not that keen on the code around the unittesting, but -what the heck- it should pop up during testing ;-)
Member
Author
|
@fgeorgatos: Thanks for the review, fixed the overly-complicated remark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #674, after making sure the unit tests catch the bug.