Skip to content

fix Lmod version parsing for rc's, set $LMOD_IGNORE_CACHE, bump required Lmod version to 5.2, get rid of (slow) for detecting module dirs#780

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:lmod_5.2
Dec 10, 2013
Merged

fix Lmod version parsing for rc's, set $LMOD_IGNORE_CACHE, bump required Lmod version to 5.2, get rid of (slow) for detecting module dirs#780
boegel merged 4 commits intoeasybuilders:developfrom
boegel:lmod_5.2

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 5, 2013

@pescobar, @pfo, @azet: please review

This was referenced Dec 5, 2013
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 5, 2013

I made sure that Lmod 5.2rc4 (or any other rc release) is not accepted, because that version of Lmod still contains bugs. From the unit tests:

EasyBuildError: 'EasyBuild crashed with an error (at easybuild/tools/modules.py:663 in update): An error occured when running \'spider -o moduleT /Users/kehoste/work/easybuild-framework/test/framework/modules\': \nLmod has detected the following error: /Users/kehoste/work/easybuild-framework/test/framework/modules/GCC/.modulerc: (GCC/.modulerc): invalid command name "module-version"\n'

@JensTimmerman
Copy link
Copy Markdown

ok

@pforai
Copy link
Copy Markdown
Contributor

pforai commented Dec 5, 2013

We're currently NOT using eb to reflect to spider that the cache needs updating as of now, but might be a nice gimmick at some point in time.

Looks good. I will review this on our production system but need to bump to 5.2 release that came out today first.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 5, 2013

@pforai: I bumped Lmod to v5.2 on our Jenkins test server, and the framework unit tests now fail on top of Lmod because this PR isn't merged in yet (unless I set $LMOD_IGNORE_CACHE, then all is well).

So, this PR is getting a bit critical.

Please let me know when you've managed to test things on your end. Any ETA for that?

@pforai
Copy link
Copy Markdown
Contributor

pforai commented Dec 10, 2013

Still doesn't work if I don't set LMOD_IGNORE_CACHE=1. Investigating....

Edit:
Was my bad, works fine now without me setting LMOD_IGNORE_CACHE=1!

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 10, 2013

@pforai: So, good to merge in?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 10, 2013

@pfo confirmed on IRC this is good to go, so merging it in!

boegel added a commit that referenced this pull request Dec 10, 2013
fix Lmod version parsing for rc's, set $LMOD_IGNORE_CACHE, bump required Lmod version to 5.2, get rid of (slow) for detecting module dirs
@boegel boegel merged commit bdbc0cb into easybuilders:develop Dec 10, 2013
@boegel boegel deleted the lmod_5.2 branch December 10, 2013 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants