Skip to content

add support for specifying multiple robot paths#786

Merged
boegel merged 8 commits intoeasybuilders:developfrom
boegel:multiple_robot_paths
Dec 12, 2013
Merged

add support for specifying multiple robot paths#786
boegel merged 8 commits intoeasybuilders:developfrom
boegel:multiple_robot_paths

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 11, 2013

No description provided.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 11, 2013

Not finished yet, the use of self.options.robot in easybuild/main.py needs to be adjusted accordingly.

…arch use --robot paths, improve implementation of finding of easyconfig files in installed easyconfigs paths, enhance coverage of unit tests on main.py via toy build unit test
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 12, 2013

This needs a review, so it becomes eligible for merging in. @JensTimmerman?

I'll look into #781 in relation to this as well, because these influence each other...

Comment thread easybuild/main.py Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix this todo? Since we have generaloption now it is fairly easy to add a new config option?

@JensTimmerman
Copy link
Copy Markdown

seems fine except for maybe it would be nice if the todo was fixed.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 12, 2013

@JensTimmerman: remark fixed, please recheck?

I'll clean up things a bit in options.py as well, but only style/indentation fixes (see next commit).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 12, 2013

No reason to hold this back any further, merging in.

boegel added a commit that referenced this pull request Dec 12, 2013
add support for specifying multiple robot paths
@boegel boegel merged commit 218c548 into easybuilders:develop Dec 12, 2013
@boegel boegel deleted the multiple_robot_paths branch December 12, 2013 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants