resolve_dependencies rewrite to make it faster and only report back actually missing deps#806
Merged
boegel merged 6 commits intoeasybuilders:developfrom Jan 21, 2014
Merged
Conversation
…ck actually missing dependencies instead of just stopping early
|
Nice. Please proceed the merge. |
Contributor
There was a problem hiding this comment.
replace this with
for i,entry in enumerate(unprocessed):
Member
Author
There was a problem hiding this comment.
hmm, I seem to recall there was a reason I wasn't using enumerate, but I can't see why anymore
anyway: fixed :)
Contributor
|
@boegel some minor remarks |
Contributor
|
@boegel ok |
Conflicts: easybuild/main.py
Member
Author
|
Jenkins: please test this |
Member
Author
|
fixed merge conflict with develop, merging in, thanks for the reveiw @stdweird! |
boegel
added a commit
that referenced
this pull request
Jan 21, 2014
resolve_dependencies rewrite to make it faster and only report back actually missing deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes #763