gen_builddir: no unique dir if cleanoldbuild is set#809
Merged
boegel merged 6 commits intoeasybuilders:developfrom Feb 7, 2014
Merged
gen_builddir: no unique dir if cleanoldbuild is set#809boegel merged 6 commits intoeasybuilders:developfrom
boegel merged 6 commits intoeasybuilders:developfrom
Conversation
|
Automatic reply from Jenkins: Can I test this? |
Member
|
Jenkins: ok to test |
Contributor
There was a problem hiding this comment.
please remove this. code above must be able to deal with this as is.
Member
Author
There was a problem hiding this comment.
This will fail. cleanupoldbuild is set to True by default, meaning that the loop below will fail. Should I split it off into a seperate test?
Member
There was a problem hiding this comment.
I'll take another look later to make sure, since I'm confused now. ;-)
Contributor
There was a problem hiding this comment.
it's forced False to make sure it doesn't get "cleaned up" so each iteration tries a new incremental directory
Member
Member
Author
|
@boegel ready to go |
boegel
added a commit
that referenced
this pull request
Feb 7, 2014
gen_builddir: no unique dir if cleanoldbuild is set
Member
|
Merged, thanks @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.