complete implementation of (very) initial support for easyconfig format 2.0 by boegel · Pull Request #810 · easybuilders/easybuild-framework

boegel · 2014-01-14T14:08:04Z

Building gzip with the included gzip.eb works, version and toolchain can be specified, default values are picked according to the [DEFAULT] section.

Examples of usage:

$ eb ~/work/easybuild-framework/test/framework/easyconfigs/v2.0/gzip.eb -ld
...
== 2014-01-14 10:10:19,469 main.module_generator DEBUG Obtained module name gzip/1.4
...
== COMPLETED: Installation ended successfully
$ module av gzip/1.4
----- /Users/kehoste/.local/easybuild/modules/all -----
gzip/1.4

$ eb ~/work/easybuild-framework/test/framework/easyconfigs/v2.0/gzip.eb -ld --software-version=1.5 --toolchain=goolf,1.4.10
...
== 2014-01-14 14:12:44,554 main.module_generator DEBUG Obtained module name gzip/1.5-goolf-1.4.10
...
== COMPLETED: Installation ended successfully
$ module av gzip/1.5-goolf-1.4.10
----- /Users/kehoste/.local/easybuild/modules/all -----
gzip/1.5-goolf-1.4.10

…version operator parsing failure

…), start implementation of get_specs_for function

…True to allowed builtins used in Python header

…ment asdict function to obtain dict representation of EasyConfig instance

…d new format

…it tests

…ize toy build unit test module

fgeorgatos · 2014-01-14T23:12:03Z

is the avoidance of templates on the 2 lines above intentional?

@boegel can you use at least one template constant here; it should still work.

OK, used constants for both of these.

…onfig, fix example gzip.eb easyconfig

stdweird · 2014-01-19T16:01:58Z

so, most of the PR is about adding yet another argument (specs) and just pass it along. all options that are passed through from main to easyconfig should be packed in eg a dict or another object. (for now it looks like check_osdeps and specs are the ones)

all current arguments can be left if they belong to the API, but should marked deprecated.

at the very least update the docstring when adding new arguments

reworked to only have build_options and build_specs class parameters, both dictionaries

boegel · 2014-01-20T23:20:46Z

@stdweird: I took care of all remarks, but I still need to make the build_options and build_specs class parameters trickly up to main.py and do some cleanup in those function signatures...

stdweird · 2014-01-21T07:13:15Z

should this be the default instead of None? you can make the condition to log a simple ```if 'valid_module_classes' in build_option.

stdweird · 2014-01-21T08:17:22Z

@boegel 2nd pass done, i made some remarks that i deleted again because the coffee hasn't kicked in yet....

boegel · 2014-01-21T12:57:47Z

@stdweird: second round of remarks covered, so good to go, and continue in future PRs?

stdweird · 2014-01-21T13:07:51Z

@boegel 2 tiny remarks, ready to merge

boegel · 2014-01-21T13:26:37Z

Last tiny remarks resolved, merging in this beast.
Thanks for the reviews @stdweird!

complete implementation of (very) initial support for easyconfig format 2.0

boegel added 9 commits January 8, 2014 18:59

define two types of default operator, exit with error on (toolchain) …

83e6b2d

…version operator parsing failure

clean up imports

80a5ee9

fix parsing w.r.t. key-value entries in sections (just pass them down…

ca3d297

…), start implementation of get_specs_for function

further flesh out get_config_dict to something that works, add False/…

ad1ae5b

…True to allowed builtins used in Python header

pass down version/toolchain specifications to parsing function, imple…

62b3fe2

…ment asdict function to obtain dict representation of EasyConfig instance

add unit test for checking equivalency of easyconfigs files in old an…

aa14304

…d new format

make sure versions are provided as strings in easyconfig dict, fix un…

ccb30ff

…it tests

pass down software build specs from command line easyconfig parser

2cc2cd5

add unit test for toy build using format 2.0 easyconfig file, reorgan…

0528f1b

…ize toy build unit test module

fgeorgatos reviewed Jan 14, 2014
View reviewed changes

boegel added 3 commits January 15, 2014 18:14

make sure that requested version and toolchain are supported by easyc…

347d405

…onfig, fix example gzip.eb easyconfig

fix easyconfigversion unit tests w.r.t. parsing failures

24ddd56

fix easyconfig parser unit test, default version is first listed version

fff443e

stdweird reviewed Jan 19, 2014
View reviewed changes

fix minor remarks + docstrings

f7a1fe5

stdweird reviewed Jan 21, 2014
View reviewed changes

boegel added 3 commits January 21, 2014 11:32

rework get_config_dict to accept 'toolchain' key in build specs

ffce5b1

for couple of minor remarks

271da4b

make sure comparison of VersionOperator instance with None works

e201379

fix updates to build_specs in process_software_build_specs

1aca170

boegel added a commit that referenced this pull request Jan 21, 2014

Merge pull request #810 from boegel/format2_ctd

e963d91

complete implementation of (very) initial support for easyconfig format 2.0

boegel merged commit e963d91 into easybuilders:develop Jan 21, 2014

boegel deleted the format2_ctd branch January 21, 2014 13:26

Flamefire mentioned this pull request Dec 5, 2023

use source toolchain version when passing only --try-toolchain #4395

Merged

Conversation

boegel commented Jan 14, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Jan 20, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stdweird commented Jan 21, 2014

Uh oh!

boegel commented Jan 21, 2014

Uh oh!

stdweird commented Jan 21, 2014

Uh oh!

boegel commented Jan 21, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants