Move the default config.cfg to $XDG_CONFIG_HOME#820
Merged
boegel merged 4 commits intoeasybuilders:developfrom Feb 9, 2014
Merged
Move the default config.cfg to $XDG_CONFIG_HOME#820boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
The new place for config.cfg is now $XDG_CONFIG_HOME/easybuild/config.cfg
|
Automatic reply from Jenkins: Can I test this? |
Contributor
There was a problem hiding this comment.
use the expanduser code instead of HOME. (make sure the line doesn't become too long)
Member
Author
There was a problem hiding this comment.
No problem for me but why? I don't see the advantage of using expanduser over $HOME?
Contributor
There was a problem hiding this comment.
apparently it's the proper way to do it (eg in case one would ever use EB on windows ;). (don't blame me, someone also had to tell me ;)
Member
|
Jenkins: ok to test |
Member
Author
|
@boegel ready to merge. |
Contributor
|
@boegel ready to merge |
Member
There was a problem hiding this comment.
I suggest to split this up in two lines:
xdg_config_home = os.environ.get('XDG_CONFIG_HOME', os.path.join(os.path.expanduser('~'), ".config")
newpath = os.path.join(xdg_config_home, "easybuild")
Member
|
@wpoely86: one small remark, looks good to go otherwise |
Member
Author
|
@boegel Done, good to go. |
Member
boegel
added a commit
that referenced
this pull request
Feb 9, 2014
Move the default config.cfg to $XDG_CONFIG_HOME
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new place for config.cfg is now
$XDG_CONFIG_HOME/easybuild/config.cfg