Skip to content

Provide better build details#824

Merged
boegel merged 11 commits intoeasybuilders:developfrom
stdweird:add_go_args
Jan 30, 2014
Merged

Provide better build details#824
boegel merged 11 commits intoeasybuilders:developfrom
stdweird:add_go_args

Conversation

@stdweird
Copy link
Copy Markdown
Contributor

Improve the build details:

  • refactor code (in preparation of proper reproducability)
  • log the command line
  • add the command line to the buildstats

@stdweird
Copy link
Copy Markdown
Contributor Author

@boegel one down

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me, we should bump to 2013 in all code files to 2014...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, actually only in the ones that are changed...

@ghost ghost assigned fgeorgatos and boegel Jan 29, 2014
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 29, 2014

Two tiny metadata remarks, let me know what you think.

Code modifications look fine to me.

@stdweird
Copy link
Copy Markdown
Contributor Author

@boegel remarks addressed

@stdweird
Copy link
Copy Markdown
Contributor Author

@boegel fixed

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 30, 2014

@stdweird: Allright, merging in, thanks!

boegel added a commit that referenced this pull request Jan 30, 2014
Provide better build details
@boegel boegel merged commit eead8d1 into easybuilders:develop Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants