properly parse dependencies in easyconfig format v2#841
Merged
boegel merged 16 commits intoeasybuilders:developfrom Feb 10, 2014
Merged
properly parse dependencies in easyconfig format v2#841boegel merged 16 commits intoeasybuilders:developfrom
boegel merged 16 commits intoeasybuilders:developfrom
Conversation
…mework into typecheck_format2
…mework into typecheck_format2
…sed by Convert instance
…parse dependencies in format v2 using parse_dependency/Dependency
…btain name/version/versionsuffix/toolchain
…lation to dict to _parse_dependency method in EasyConfig class
Member
Author
There was a problem hiding this comment.
crap, ok
So the first thing is to make sure the unit tests trigger this... :)
Member
Author
|
@stdweird: fixed issue with typo not being seen by unit tests, I was forced to make some additional code changes w.r.t. |
Contributor
|
@boegel looks ok. if unittetsts work, merge it in, i'll add some more v2 code afterwards. |
Member
Author
|
Jenkins gave the green light, so merging this in. Thanks for the review @stdweird! |
boegel
added a commit
that referenced
this pull request
Feb 10, 2014
properly parse dependencies in easyconfig format v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stdweird: this is the missing bit from #827
I was force to move around this (
format.version.ConfigObjVersiontoformat.format.EBConfigObj) to avoid cyclic dependencies