Skip to content

Allow to keep the build dir after succesful build#853

Merged
boegel merged 7 commits intoeasybuilders:developfrom
wpoely86:cleanupbuild
May 20, 2014
Merged

Allow to keep the build dir after succesful build#853
boegel merged 7 commits intoeasybuilders:developfrom
wpoely86:cleanupbuild

Conversation

@wpoely86
Copy link
Copy Markdown
Member

Set the option cleanupbuild to False to keep the build dir after a
succesful build. Can be helpfull for debugging purposes.

I needed something like this to test the Clang eb.

Set the option cleanupbuild to False to keep the build dir after a
succesful build. Can be helpfull for debugging purposes.
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 18, 2014

Shouldn't this be a command line option --cleanupbuilddir or --keepbuilddir (I like the 2nd one better, since that's the opposite of the default) instead?

@wpoely86
Copy link
Copy Markdown
Member Author

Commandline option is fine for me too. But that goes for all cleanup* options in the easyconfig.

@stdweird
Copy link
Copy Markdown
Contributor

i agree with @boegel it makes not much sense as an easyconfig option (if the build dir is really needed after the installation to make the software work, i think that software needs a modified install step if buildininstalldir is not enough).
if this is for debugging purposes, a commandline option is the (only) way to go.

@boegel boegel modified the milestones: v1.X, v1.13 Mar 28, 2014
boegel and others added 5 commits May 20, 2014 11:21
Conflicts:
	easybuild/framework/easyconfig/default.py
replace 'cleanupbuild' easyconfig parameter by '--cleanup-builddir' command line option, and enhance unit tests
Comment thread easybuild/tools/options.py Outdated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/run/build ?

It's cleaned after a sucessful build & install and not after a EB run?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it "Cleanup build dir after successful installation.", and I'll merge it in

@wpoely86
Copy link
Copy Markdown
Member Author

Looks good

@wpoely86
Copy link
Copy Markdown
Member Author

@boegel ready

@boegel
Copy link
Copy Markdown
Member

boegel commented May 20, 2014

Going in, thanks @wpoely86!

boegel added a commit that referenced this pull request May 20, 2014
Allow to keep the build dir after succesful build
@boegel boegel merged commit d4d5d36 into easybuilders:develop May 20, 2014
@wpoely86 wpoely86 deleted the cleanupbuild branch May 20, 2014 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants