Skip to content

fix use of spider in case it's not in $PATH#861

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:pfo_fix_spider
Feb 26, 2014
Merged

fix use of spider in case it's not in $PATH#861
boegel merged 1 commit intoeasybuilders:developfrom
boegel:pfo_fix_spider

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 20, 2014

debugged by @pforai, who is too lazy to make the PR himself 😫

@JensTimmerman
Copy link
Copy Markdown

JensTimmerman commented Feb 21, 2014

fine by me

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 22, 2014

This should probably be extended with an option to skip the spider thing all together. It's fairly useless since EasyBuild relies on $LMOD_IGNORE_CACHE...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2014

This is a pure bug fix, while adding an option to skip spider usage is a feature.

Since I'm planning to release an v1.11.1 bugfix release, I'll merge this in as is, and look into adding an option to escape spider usage later (in another PR).

boegel added a commit that referenced this pull request Feb 26, 2014
@boegel
Merge pull request #861 from boegel/pfo_fix_spider
0bd0ab4 
fix use of spider in case it's not in $PATH
@boegel boegel merged commit 0bd0ab4 into easybuilders:develop Feb 26, 2014
@boegel boegel deleted the pfo_fix_spider branch February 26, 2014 20:46
This was referenced Feb 26, 2014
Merged
Merged
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2014

For future reference: the bug fixed in this PR manifests itself as follows in EasyBuild v1.11.0:

Traceback (most recent call last):
  File "test/framework/modulestool.py", line 141, in test_lmod_specific
    self.assertTrue(lmod.update(fake=True), "Updated local Lmod spider cache is non-empty")
  File "/Users/kehoste/work/easybuild-framework/easybuild/tools/modules.py", line 653, in update
    proc = subprocess.Popen(cmd, stdout=PIPE, stderr=PIPE, env=os.environ)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 672, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1202, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

The unit test added in #873 triggers this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @JensTimmerman