Skip to content

clean up assertErrorRegex copy-pasting in unit test modules via central EnhancedTestCase#877

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:assertErrorRegex
Feb 28, 2014
Merged

clean up assertErrorRegex copy-pasting in unit test modules via central EnhancedTestCase#877
boegel merged 2 commits intoeasybuilders:developfrom
boegel:assertErrorRegex

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 27, 2014

No description provided.

@boegel boegel added this to the v1.12 milestone Feb 27, 2014
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2014

I found a totally broken/useless test in module_generator.py during this cleanup, which I simply removed. The test was nonsense, and was left unnoticed because the local assertErrorRegex function wasn't catching the fact that no exception was being raised at all...

@stdweird
Copy link
Copy Markdown
Contributor

@boegel excellent cleanup!.

boegel added a commit that referenced this pull request Feb 28, 2014
clean up assertErrorRegex copy-pasting in unit test modules via central EnhancedTestCase
@boegel boegel merged commit c798cc9 into easybuilders:develop Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants