Skip to content

fix toy source code#880

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_toy_sources
Mar 6, 2014
Merged

fix toy source code#880
boegel merged 2 commits intoeasybuilders:developfrom
boegel:fix_toy_sources

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 6, 2014

Recent compilers (e.g. the default gcc on OS X 10.9) complains about a faulty main function signature in the toy example:

$ gcc toy.c 
toy.c:3:5: error: second parameter of 'main' (argument array) must be of type 'char **'
int main(int argc, char* *argv[]){
    ^
1 error generated.

fixed by applying the following patch:

--- toy-0.0/toy.source.orig 2014-03-06 18:53:40.000000000 +0100
+++ toy-0.0/toy.source  2014-03-06 18:48:16.000000000 +0100
@@ -1,6 +1,6 @@
 #include <stdio.h>

-int main(int argc, char* *argv[]){
+int main(int argc, char* argv[]){

     printf("I'm a toy, and proud of it.\n");
     return 0;

@boegel boegel added this to the v1.12 milestone Mar 6, 2014
@boegel boegel added bug labels Mar 6, 2014
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 6, 2014

Nothing much to review here, so merging this in as is.

boegel added a commit that referenced this pull request Mar 6, 2014
@boegel
Merge pull request #880 from boegel/fix_toy_sources
b983ae6 
fix toy source code
@boegel boegel merged commit b983ae6 into easybuilders:develop Mar 6, 2014
@boegel boegel deleted the fix_toy_sources branch March 6, 2014 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug report priority:medium

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

1 participant

@boegel