add features to properly support using a shared install target with multiple users#902
Conversation
|
In my opinion it's ok to override the umask for the final installation (as it currently stands in the post_install step). This helps protect against careless use of --force and --robot (for example). |
There was a problem hiding this comment.
this will fail hard if the group is not known (aka typo)
There was a problem hiding this comment.
(ok, at this point one can maybe assume that this works, if it's properly catched/checked above)
There was a problem hiding this comment.
this should be a if/elif construct to set self.group
|
@boegel reviewed |
|
btw, does one still need |
…really need, enhance unit tests
|
@stdweird: yes, once you have things set up correctly with set_gid bits on the relevant directories, you shouldn't need |
|
@stdweird: remarks fixed, please check again? |
in the end, this should add support for:
--umask: set custom umask (and don't override it)--group: set group to be used in installations (only verify)--set-gid-bit: set group ID bit on directories (to make group ownership trickle down to new dirs/files)--sticky-bit: set sticky bit on directories (to avoid that one user destroys the work of another user)