Add env filter regex option for test reports#959
Merged
boegel merged 9 commits intoeasybuilders:developfrom Jul 4, 2014
Merged
Add env filter regex option for test reports#959boegel merged 9 commits intoeasybuilders:developfrom
boegel merged 9 commits intoeasybuilders:developfrom
Conversation
There is now a regex filter option to clean out the environment before writting the test report.
Member
There was a problem hiding this comment.
First of all, store the value returned by build_option('environment-filter-regex') outside the for loop
Second: how can this ever work? build_option('environment-filter-regex') will return a string, which doesn't have .search? You're not compiling the regex anywhere (which you can/should also do outside of the for loop).
The unit tests should also be extended to verify this functionality (since this must be broken pretty hard right now).
Member
Author
There was a problem hiding this comment.
It works. Give it a spin.
Member
Author
|
@boegel reworked a bit only a unit test is missing. Will try to add. |
vsc-base update
rename --env-filter-regex to --test-report-env-filter, add unit test
… reported correctly
correct unit test, also check whether use --test-report-env-filter is reported correctly
|
Merged build started. |
Member
boegel
added a commit
that referenced
this pull request
Jul 4, 2014
Add env filter regex option for test reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a regex filter option to clean out the environment before
writting the test report.