add iimpi toolchain definition & fix --list--toolchains#993
Merged
boegel merged 4 commits intoeasybuilders:developfrom Aug 6, 2014
Merged
add iimpi toolchain definition & fix --list--toolchains#993boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
@wpoely86: please review? |
Member
There was a problem hiding this comment.
Maybe add a comment that these should be alphabetical? Or add a sort?
Member
|
Looks good |
Member
There was a problem hiding this comment.
Maybe pick a better name? intel seems to suggest that the MKL is also part of it.
Member
Author
There was a problem hiding this comment.
should be Iimpi, the Intel class is already defined in intel.py
Member
Author
|
Going in, thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Aug 6, 2014
add iimpi toolchain definition & fix --list--toolchains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.