Merged
Conversation
3737448 to
6bfca88
Compare
Signed-off-by: Jayson Reis <[email protected]>
6bfca88 to
e604f61
Compare
andreoliwa
suggested changes
Oct 13, 2017
src/efs/efs3.py
Outdated
| @@ -0,0 +1,58 @@ | |||
| """Eatfirst FileSystem for S3.""" | |||
There was a problem hiding this comment.
💄 "EatFirst", capital "F".
There are other wrong comments with this spelling.
src/efs/efs3.py
Outdated
| from fs.s3fs import thread_local | ||
|
|
||
|
|
||
| class EFS3(S3FS): |
There was a problem hiding this comment.
Now that we are messing with this untouched part of the code... why not EatFirstS3?
| from .efs3 import EFS3 | ||
|
|
||
|
|
||
| class EFS: |
There was a problem hiding this comment.
Now that we are messing with this untouched part of the code... why not a better name like EatFirstFS or EatFirstFileSystem?
EFS and EFS3 look very similar, and they should not be.
EFS3 looks like the version 3 of EFS.
Signed-off-by: Jayson Reis <[email protected]>
andreoliwa
approved these changes
Oct 16, 2017
docs/usage.rst
Outdated
|
|
||
| import efs | ||
|
|
||
| # There is no need to initialise it because it will always the current app. |
There was a problem hiding this comment.
💄 A verb is missing in the sentence, right? "It will always [?] the current app"
Signed-off-by: Jayson Reis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.