Add tuco library with its tests by jaysonsantos · Pull Request #3 · eatfirst/python-tuco

jaysonsantos · 2017-12-20T14:23:38Z

No description provided.

andreoliwa

Let's talk about class names (or not), and I couldn't make tox work (probably I'm doing something wwrong or missing).

andreoliwa · 2018-01-02T17:23:33Z

docs/usage.rst

+
+        fsm_class = db.Column(db.String)
+        model_class = db.Column(db.String)
+        current_state= = db.Column(db.String)


Typo: = =.

andreoliwa · 2018-01-02T17:30:21Z

docs/usage.rst

+Using events with enums instead of simple strings
+=================================================
+
+In case you want to have a sane event naming, probably it is better to use constants or python's enum module.


"Python" with uppercase "P".

andreoliwa · 2018-01-02T17:30:36Z

docs/usage.rst

+        refunded = properties.FinalState()
+        charged_back = properties.FinalState()
+
+The state machine will be validated when it gets parsed by python interpreter and below you can find a visual


"Python" with uppercase "P".

andreoliwa · 2018-01-02T17:39:27Z

docs/usage.rst

+                                     self.current_state_instance.timeout.timedelta))
+                db.session.add(timeout)
+
+Using events with enums instead of simple strings


Nice example. It works for future code, and we don't need to change our Cave code right now. 👏

andreoliwa · 2018-01-02T18:26:11Z

src/tuco/base.py

+
+import pytz
+
+from tuco.exceptions import TucoAlreadyLocked, TucoEventNotFound, TucoInvalidStateChange, TucoInvalidStateHolder


Should we use the suffix Error for all exceptions (AlreadyLockedError, EventNotFoundError...)?
Is this a Python convention?
I read this once, but I couldn't find the reference now.

Or just replace Tuco by FSM: FSMAlreadyLocked, FSMEventNotFound...
Just because the base class is called FSM (because it makes more sense, I agree), not Tuco.

They were all prefixed with FSM but I was afraid of it conflicting with other libraries in the future.

The names could conflict if a project uses Tuco and another FSM module at the same time, which is unlikely.
But the Tuco prefix is not a big issue, it's just that I still don't like the project name.

I think the Error suffix is more important.
We should stick to Python conventions if we want our module to be used by devs.
Although I'm not sure if using the Error suffix is actually a convention.

If you are switching between state machines you could potentially have the two at the same time. I will also change the suffix

Why would someone switch to another FSM module? 😄

idk, if they found a better one, why not?

andreoliwa · 2018-01-02T18:52:57Z

src/tuco/base.py

+        return self
+
+    def __exit__(self, exc_type, exc_val, exc_tb):
+        """If FSMAlreadyLocked did not throw, unlock the machine."""


Class name doesn't match the code, it should be TucoAlreadyLocked (depending on what's decided from the comment above).

andreoliwa · 2018-01-02T19:09:37Z

src/tuco/generate_graph.py

+from tuco.properties import Error, Event, FinalState, State, Timeout
+
+
+class GenerateGraph:


Classes should be nouns, something like GraphBuilder.
I would not use GraphGenerator to not mix it with Python generators.

I would also rename the module file from generate_graph.py to graph_builder.py (or whatever noun is used).

andreoliwa · 2018-01-02T19:42:08Z

tox.ini

    docutils
    check-manifest
    flake8
+    flake8-mypy


We could add all the plugins we use for other projects, no?
Those:

flake8-blind-except = "*" flake8-bugbear = "*" flake8-comprehensions = "*" flake8-debugger = "*" flake8-docstrings = "*" flake8-isort = "*" flake8-mypy = "*" flake8-polyfill = "*" flake8-pytest = "*" flake8-quotes = "*"

(after our Slack discussion)
Well, we could remove most of those actually.
They are “purist” plugins
We already have mypy, isort, and flake8 itself, they are good enough.

Maybe keep the flake8-quotes, for quote consistency?

My point is: when I see a project that has standardised code, with lots of comments, it looks reliable.
We could remove flake8-docstrings, which is picky and adds a lot of noise comments.
We should just keep good documentation by ourselves, without any flake8 police.

So the new list could be:

flake8-isort flake8-mypy flake8-quotes

Thoughts?

All, good. Changing it on my side.

andreoliwa · 2018-01-02T19:57:45Z

README.rst

-To run the all tests run::
+Make sure you have a running redis instance and to run the all tests run::

    tox


I tried to clone it locally to run tests:

git clone [email protected]:eatfirst/python-tuco.git

Set up a virtual environment with pyenv (and dotfiles).

pip install tox

tox

And the result was:

$ tox GLOB sdist-make: /Users/wagneraugusto/eatfirst/python-tuco/setup.py clean create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/clean clean installdeps: coverage clean installed: coverage==4.4.2 clean runtests: PYTHONHASHSEED='1402629706' clean runtests: commands[0] | coverage erase check create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/check check installdeps: docutils, check-manifest, flake8, flake8-mypy, readme-renderer, pygments, isort check installed: attrs==17.4.0,bleach==2.1.2,check-manifest==0.36,docutils==0.14,flake8==3.5.0,flake8-mypy==17.8.0,html5lib==1.0.1,isort==4.2.15,mccabe==0.6.1,mypy==0.560,psutil==5.4.3,pycodestyle==2.3.1,pyflakes==1.6.0,Pygments==2.2.0,readme-renderer==17.2,six==1.11.0,typed-ast==1.1.0,webencodings==0.5.1 check runtests: PYTHONHASHSEED='1402629706' check runtests: commands[0] | python setup.py check --strict --metadata --restructuredtext running check check runtests: commands[1] | check-manifest /Users/wagneraugusto/eatfirst/python-tuco lists of files in version control and sdist match check runtests: commands[2] | flake8 src tests setup.py check runtests: commands[3] | isort --verbose --check-only --diff --recursive src tests setup.py /#######################################################################\ `sMMy` .yyyy- ` ##soos## ./o. ` ``..-..` ``...`.`` ` ```` ``-ssso``` .s:-y- .+osssssso/. ./ossss+:so+:` :+o-`/osso:+sssssssso/ .s::y- osss+.``.`` -ssss+-.`-ossso` ssssso/::..::+ssss:::. .s::y- /ssss+//:-.` `ssss+ `ssss+ sssso` :ssss` .s::y- `-/+oossssso/ `ssss/ sssso ssss/ :ssss` .y-/y- ````:ssss` ossso. :ssss: ssss/ :ssss. `/so:` `-//::/osss+ `+ssss+-/ossso: /sso- `osssso/. \/ `-/oooo++/- .:/++:/++/-` .. `://++/. isort your Python imports for you so you don't have to VERSION 4.2.15 \########################################################################/ SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/generate_graph.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/properties.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/__init__.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/exceptions.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/base.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/meta.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/decorators.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/memory.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/__init__.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/redis.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/base.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/test_tuco.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/example_fsm.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/__init__.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/test_graph_creation.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/setup.py Everything Looks Good! py34 create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/py34 ERROR: InterpreterNotFound: python3.4 py35 create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/py35 ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.5: b"pyenv: python3.5: command not found\\n\\nThe `python3.5\' command exists in these Python versions:\\n 3.5.4\\n\\n"',) py36 create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/py36 ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) pypy create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/pypy ERROR: InterpreterNotFound: pypy report create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/report report installdeps: coverage report installed: coverage==4.4.2 report runtests: PYTHONHASHSEED='1402629706' report runtests: commands[0] | coverage combine --append No data to combine ERROR: InvocationError: '/Users/wagneraugusto/eatfirst/python-tuco/.tox/report/bin/coverage combine --append' docs create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/docs ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) _________________________________________________________________________________________________ summary __________________________________________________________________________________________________ clean: commands succeeded check: commands succeeded ERROR: py34: InterpreterNotFound: python3.4 ERROR: py35: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.5: b"pyenv: python3.5: command not found\\n\\nThe `python3.5\' command exists in these Python versions:\\n 3.5.4\\n\\n"',) ERROR: py36: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) ERROR: pypy: InterpreterNotFound: pypy ERROR: report: commands failed ERROR: docs: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',)

You need to have all this python versions in your path if you want to run tests in all version

I installed Python 3.4.7, after setting some compilation flags on MacOS:

CFLAGS="-I$(brew --prefix openssl)/include -I$(xcrun --show-sdk-path)/usr/include" \ LDFLAGS="-L$(brew --prefix openssl)/lib" \ pyenv install -v 3.4.7

But still no success with tox:

ERROR: py34: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.4: b"pyenv: python3.4: command not found\\n\\nThe `python3.4\' command exists in these Python versions:\\n 3.4.7\\n\\n"',) ERROR: py35: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.5: b"pyenv: python3.5: command not found\\n\\nThe `python3.5\' command exists in these Python versions:\\n 3.5.4\\n\\n"',) ERROR: py36: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) ERROR: report: commands failed ERROR: docs: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',)

Full log:

$ tox GLOB sdist-make: /Users/wagneraugusto/eatfirst/python-tuco/setup.py clean installed: coverage==4.4.2 clean runtests: PYTHONHASHSEED='2128799634' clean runtests: commands[0] | coverage erase check installed: bleach==2.1.2,check-manifest==0.36,docutils==0.14,flake8==3.5.0,flake8-quotes==0.13.0,html5lib==1.0.1,isort==4.2.15,mccabe==0.6.1,mypy==0.560,psutil==5.4.3,pycodestyle==2.3.1,pyflakes==1.6.0,Pygments==2.2.0,readme-renderer==17.2,six==1.11.0,typed-ast==1.1.0,webencodings==0.5.1 check runtests: PYTHONHASHSEED='2128799634' check runtests: commands[0] | python setup.py check --strict --metadata --restructuredtext running check check runtests: commands[1] | check-manifest /Users/wagneraugusto/eatfirst/python-tuco lists of files in version control and sdist match check runtests: commands[2] | flake8 src tests setup.py check runtests: commands[3] | isort --verbose --check-only --diff --recursive src tests setup.py /#######################################################################\ `sMMy` .yyyy- ` ##soos## ./o. ` ``..-..` ``...`.`` ` ```` ``-ssso``` .s:-y- .+osssssso/. ./ossss+:so+:` :+o-`/osso:+sssssssso/ .s::y- osss+.``.`` -ssss+-.`-ossso` ssssso/::..::+ssss:::. .s::y- /ssss+//:-.` `ssss+ `ssss+ sssso` :ssss` .s::y- `-/+oossssso/ `ssss/ sssso ssss/ :ssss` .y-/y- ````:ssss` ossso. :ssss: ssss/ :ssss. `/so:` `-//::/osss+ `+ssss+-/ossso: /sso- `osssso/. \/ `-/oooo++/- .:/++:/++/-` .. `://++/. isort your Python imports for you so you don't have to VERSION 4.2.15 \########################################################################/ SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/properties.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/__init__.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/exceptions.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/graph_builder.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/base.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/meta.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/decorators.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/memory.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/__init__.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/redis.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/src/tuco/locks/base.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/test_tuco.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/example_fsm.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/__init__.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/tests/test_graph_creation.py Everything Looks Good! SUCCESS: /Users/wagneraugusto/eatfirst/python-tuco/setup.py Everything Looks Good! check runtests: commands[4] | mypy src tests setup.py py34 create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/py34 ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.4: b"pyenv: python3.4: command not found\\n\\nThe `python3.4\' command exists in these Python versions:\\n 3.4.7\\n\\n"',) py35 create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/py35 ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.5: b"pyenv: python3.5: command not found\\n\\nThe `python3.5\' command exists in these Python versions:\\n 3.5.4\\n\\n"',) py36 create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/py36 ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) report installed: coverage==4.4.2 report runtests: PYTHONHASHSEED='2128799634' report runtests: commands[0] | coverage combine --append No data to combine ERROR: InvocationError: '/Users/wagneraugusto/eatfirst/python-tuco/.tox/report/bin/coverage combine --append' docs create: /Users/wagneraugusto/eatfirst/python-tuco/.tox/docs ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) _________________________________________________________________________________________________ summary __________________________________________________________________________________________________ clean: commands succeeded check: commands succeeded ERROR: py34: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.4: b"pyenv: python3.4: command not found\\n\\nThe `python3.4\' command exists in these Python versions:\\n 3.4.7\\n\\n"',) ERROR: py35: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.5: b"pyenv: python3.5: command not found\\n\\nThe `python3.5\' command exists in these Python versions:\\n 3.5.4\\n\\n"',) ERROR: py36: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',) ERROR: report: commands failed ERROR: docs: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\\n\\nThe `python3.6\' command exists in these Python versions:\\n 3.6.2\\n 3.6.3\\n\\n"',)

I will investigate it later.

as you are using pyenv it changes the paths so you have to run this before pyenv local 3.4.7 3.6.2 3.5.4

At the end of the message it shows the pyenv output

ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('Failed to get version_info for python3.6: b"pyenv: python3.6: command not found\n\nThe `python3.6' command exists in these Python versions:\n 3.6.2\n 3.6.3\n\n"',)

so you have to run this before pyenv local 3.4.7 3.6.2 3.5.4

I don't know how to do that, never mind.
It's working, so all good.
I will read more about tox in the future.
And people that want to fork Tuco will probably know how to use tox.

andreoliwa

Approve it, so we can make the repo public.
The changes will be discussed and fixed later.

coveralls · 2018-01-04T15:51:32Z

Changes Unknown when pulling 34dcb87 on initial-library-data into ** on master**.

coveralls · 2018-01-04T16:05:23Z

Changes Unknown when pulling 613d8d7 on initial-library-data into ** on master**.

coveralls · 2018-01-04T16:08:18Z

Changes Unknown when pulling 1c05216 on initial-library-data into ** on master**.

coveralls · 2018-01-04T16:08:18Z

Changes Unknown when pulling 1c05216 on initial-library-data into ** on master**.

coveralls · 2018-01-04T16:43:03Z

Changes Unknown when pulling c8e4875 on initial-library-data into ** on master**.

It is a version with support of python 2 and also we should target cPython at least for now

coveralls · 2018-01-04T16:55:55Z

Changes Unknown when pulling 56f655d on initial-library-data into ** on master**.

coveralls · 2018-01-04T16:55:55Z

Changes Unknown when pulling 56f655d on initial-library-data into ** on master**.

jaysonsantos · 2018-01-04T17:02:09Z

Travis working but the job docs will be broken until we release the frist version https://travis-ci.org/eatfirst/python-tuco/jobs/325114115

andreoliwa · 2018-01-04T19:34:58Z

.travis.yml

      env:
        - TOXENV=py36,report,coveralls
-    - python: 'pypy-5.4'
+    - python: '3.6'


Why 3.6 twice (lines 18 and 21)?

This is a matrix, so it is python 3.6 and env TOXENV=docs so it has a dedicated docs tasks

Hmm... so using - TOXENV=py36,report,coveralls,docs generates a different output?
I'm trying to understand how it works.

No, it will create one TOXENV=py32,report,coveralls and one with TOXENV=docs both running with travis python3.6 support

coveralls · 2018-01-05T13:09:54Z

Changes Unknown when pulling 419e671 on initial-library-data into ** on master**.

jaysonsantos force-pushed the initial-library-data branch from 4b62446 to d1d2505 Compare December 20, 2017 14:36

Add tuco library with its tests

1c58681

jaysonsantos force-pushed the initial-library-data branch from d1d2505 to 1c58681 Compare December 20, 2017 14:53

jaysonsantos added 6 commits December 21, 2017 13:27

Refactor svg tests

f1e6ac8

Documentation improvements

12825ae

Test empty state machines

21ef5ee

Remove unused exceptions

8d797fa

Change graph generation to a class based version

2631949

Break iterate_states into smaller pieces

d426f2c

andreoliwa requested changes Jan 2, 2018

View reviewed changes

andreoliwa approved these changes Jan 2, 2018

View reviewed changes

jaysonsantos added 5 commits January 4, 2018 14:47

Code review changes

6ca3f6c

Please test it travis

9757f3e

Use mypy without flake8 plugin

f04bd9f

Move docs to python 3.6 in .travis.yml

b1b60b9

Install graphviz before running travis tests

34dcb87

Change threaded tests to use events instead of queues

613d8d7

Add redis to travis as a service

1c05216

Change graph test to work with different versions of graphviz

c8e4875

Remove pypy from travis

56f655d

It is a version with support of python 2 and also we should target cPython at least for now

andreoliwa approved these changes Jan 4, 2018

View reviewed changes

Skip some tests in appveyor

419e671

jaysonsantos merged commit fd41fbe into master Jan 5, 2018

jaysonsantos deleted the initial-library-data branch January 5, 2018 13:38


		import pytz

		from tuco.exceptions import TucoAlreadyLocked, TucoEventNotFound, TucoInvalidStateChange, TucoInvalidStateHolder

		from tuco.properties import Error, Event, FinalState, State, Timeout


		class GenerateGraph:

Conversation

jaysonsantos commented Dec 20, 2017

Uh oh!

andreoliwa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreoliwa left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 4, 2018

Uh oh!

coveralls commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 4, 2018

Uh oh!

coveralls commented Jan 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaysonsantos commented Jan 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jan 4, 2018 •

edited

Loading

coveralls commented Jan 4, 2018 •

edited

Loading

coveralls commented Jan 4, 2018 •

edited

Loading

coveralls commented Jan 4, 2018 •

edited

Loading

coveralls commented Jan 4, 2018 •

edited

Loading

coveralls commented Jan 5, 2018 •

edited

Loading