Skip to content

Assignment 1#1

Open
ecervinka wants to merge 2 commits intomainfrom
assignment-1
Open

Assignment 1#1
ecervinka wants to merge 2 commits intomainfrom
assignment-1

Conversation

@ecervinka
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Completed Part 1 & 2

What did you learn from the changes you have made?

Remembering to save and commit the changes

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Thought about breaking the function down part by part at first

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Kernel issues.. classic

How were these changes tested?

running the cells one by one

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! One note for improvement would be to simplify your conditional logic in part b. Since is_case_sensitive is already a Boolean, you do not need to explicitly check == True or == False. You could simplify the condition by using if not is_case_sensitive: instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants