Open
Conversation
anjali-deshpande-hub
approved these changes
Mar 24, 2026
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done! Loved the various approaches you used for Q1. That's the best way to learn Python: hands-on practice!
One minor observation - he PR contains changes to assignment-1.ipynb as well. It should only contain updates to assignment_2.ipynb. For future assignments, please switch to the main branch before creating the assignment-2 branch, so that assignment-2 is branched from main rather than from assignment-1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
submitting assignment 2
What did you learn from the changes you have made?
That there's a lot of different ways to read a file
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I used a while loop for part 1 at first, then changed to a for loop after rereading the instructions
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
indentation errors
How were these changes tested?
running the code with mutliple files
A reference to a related issue in your repository (if applicable)
Checklist