Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
i created code to be added on this assignment. code in the template was incomplete, and extra code was needed to make it work
What did you learn from the changes you have made?
joining different functions and methods and make it work as a one, so it can be run smoothly.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no other approach, we were expected to use python for loops and methods for this assignment
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
few challenges, code wouldn't run properly at the beginning. errors would show up sometimes. it was difficult to connect different codes into one and make it run properly
How were these changes tested?
tested the code in different ways. added and switched parameters until i got the results i expected.
A reference to a related issue in your repository (if applicable)
Checklist