Closed
Conversation
Contributor
Contributor
|
Other than the above changelog suggestion, LGTM :) |
Contributor
Author
|
@original-brownbear what would you put in the changelog entry there? Was that an actual bug, or was it a perf fix? |
Contributor
|
@andrewvc that was an actual bug. Setting page_size == queue_size caused the pipeline to simply stall. Maybe just put: "Fixed a bug that caused a persistent queue configured to use a single page only not to process events." or something like that? |
Contributor
Author
|
@original-brownbear so, if a PQ was configured to use only one page it wouldn't process any events at all? |
Contributor
|
@andrewvc jup, exactly. |
fbdb63d to
e2fffee
Compare
e2fffee to
1ee7083
Compare
Contributor
Author
|
@original-brownbear how's it look now? |
Contributor
|
@andrewvc perfect => LGTM :) |
|
Andrew Cholakian merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the range
0a4bc...v5.6.3Also bumps the docs version.