Skip to content

Bump gemspecs for 5.6.5/5.6.6#8779

Closed
andrewvc wants to merge 1 commit intoelastic:5.6from
andrewvc:bump-gemspecs-5.6.5
Closed

Bump gemspecs for 5.6.5/5.6.6#8779
andrewvc wants to merge 1 commit intoelastic:5.6from
andrewvc:bump-gemspecs-5.6.5

Conversation

@andrewvc
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc commented Dec 1, 2017

We already have a BC for 5.6.5 so this may not make it, which is fine, there's nothing critical here.

If it doesn't, this can wait for 5.6.6

logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-patterns-core
logstash-codec-netflow (3.7.1)
logstash-codec-netflow (3.8.3)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logstash-codec-plain (3.0.5)
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-codec-rubydebug (3.0.4)
logstash-codec-rubydebug (3.0.5)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update gemspec summary

logstash-filter-geoip (4.3.1-java)
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-filter-grok (3.4.4)
logstash-filter-grok (4.0.0)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major performance improvement

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obligatory, are you sure you want to push a major plugin as the default for a patch release ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LS5 is completely unusable for us without logstash-filter-grok 4.0.0 we had a 90% reduction in grok performance in LS2 vs LS5

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the only reason it's major is that it doesn't support LS 5.4 and below. It'd be a patch release otherwise.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no new features, it just needs new LS features really.

metriks
thread_safe
logstash-filter-mutate (3.1.7)
logstash-filter-mutate (3.2.0)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support conversion of booleans to integers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to hold off this until the next minor release. It changes behavior and is arguable if the old behave was a bug or expected.

logstash-filter-mutate (3.2.0)
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-filter-ruby (3.1.1)
logstash-filter-ruby (3.1.2)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevant fix for JRuby 9k

logstash-core-plugin-api (>= 1.60, <= 2.99)
stud (~> 0.0.22)
logstash-input-gelf (3.0.6)
logstash-input-gelf (3.0.7)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update gemspec summary

mime-types (= 2.6.2)
stud (~> 0.0.22)
logstash-input-irc (3.0.4)
logstash-input-irc (3.0.5)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemspec summary

manticore (>= 0.5.4, < 1.0.0)
stud (~> 0.0, >= 0.0.17)
logstash-output-file (4.1.2)
logstash-output-file (4.2.1)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support overwrite option for file output.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a compelling reason, i would suggest to not bump this minor version for the next patch. I don't think that new functionality is expected to be included in patch versions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been our policy throughout 5.x. I'm glad to discuss changing it though. I agree it's weird in some ways.

logstash-codec-plain
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-output-pagerduty (3.0.5)
logstash-output-pagerduty (3.0.6)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary

logstash-codec-plain
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-output-pipe (3.0.4)
logstash-output-pipe (3.0.5)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary

redis
stud
logstash-output-s3 (4.0.12)
logstash-output-s3 (4.0.13)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipe

logstash-mixin-aws
stud (~> 0.0.22)
logstash-output-sns (4.0.5)
logstash-output-sns (4.0.6)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary

logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-mixin-aws (>= 1.0.0)
logstash-output-statsd (3.1.3)
logstash-output-statsd (3.1.4)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

@andrewvc andrewvc changed the title Bump gemspecs for 5.6.5 Bump gemspecs for 5.6.5/6 Dec 1, 2017
@andrewvc andrewvc changed the title Bump gemspecs for 5.6.5/6 Bump gemspecs for 5.6.5/5.6.6 Dec 1, 2017
@elasticsearch-bot elasticsearch-bot self-assigned this Dec 1, 2017
@jakelandis
Copy link
Copy Markdown
Contributor

@andrewvc - left a thumbs up or suggestions on the changes. Thanks for annotating the diff, that REALLY helps.

@elasticsearch-bot
Copy link
Copy Markdown

Andrew Cholakian merged this into the following branches!

Branch Commits
5.6 f8021db

elasticsearch-bot pushed a commit that referenced this pull request Dec 3, 2017
@andrewvc andrewvc closed this Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants