Conversation
| obtained via the GeoIP2-ISP database. | ||
| [[logstash-6-1-0]] | ||
| === Logstash 6.1.0 Release Notes | ||
| * New experimental Java execution engine for Logstash pipelines. Off by default, it can be enabled with `--experimental-java-execution` ({lsissue}7950[Issue 7950]). |
There was a problem hiding this comment.
Are the issues links supposed to render when you click the view button ?
There was a problem hiding this comment.
not really, other examples here: https://github.com/elastic/logstash/blob/v5.5.2/docs/static/releasenotes.asciidoc
There was a problem hiding this comment.
{lsissue} is an asciidoc attribute that resolves to a file path when you build the doc.
|
I browsed the core changes and didn't see any additional non-internal type changes users would care about. From memory, the plugin list seems about right (it's a fairly short cycle for the plugins). LGTM |
dedemorton
left a comment
There was a problem hiding this comment.
A few changes here and there, but nothing major.
| obtained via the GeoIP2-ISP database. | ||
| [[logstash-6-1-0]] | ||
| === Logstash 6.1.0 Release Notes | ||
| * New experimental Java execution engine for Logstash pipelines. Off by default, it can be enabled with `--experimental-java-execution` ({lsissue}7950[Issue 7950]). |
There was a problem hiding this comment.
{lsissue} is an asciidoc attribute that resolves to a file path when you build the doc.
| === Logstash 6.1.0 Release Notes | ||
| * New experimental Java execution engine for Logstash pipelines. Off by default, it can be enabled with `--experimental-java-execution` ({lsissue}7950[Issue 7950]). | ||
| * Added support for changing the <<configuring-persistent-queues,page capacity>> for an existing queue ({lsissue}8628[Issue 8628]). | ||
| * {lsissue}7692[Many], {lsissue}8776[many], {lsissue}8577[many], {lsissue}8446[many], {lsissue}8333[many], {lsissue}8163[many], {lsissue}8103[many], {lsissue}8087[many] (did I say {lsissue}7691[many]?) improvements in pipeline execution performance and memory efficiency. |
There was a problem hiding this comment.
This is sort of cute, but I think users might benefit more by seeing the issue number, especially if they are tracking a specific issue. So I would say:
- Made extensive improvements to pipeline execution performance and memory ({lsissue}7692[Issue 7692], {lsissue}8776[8776], {lsissue}8577[8577], {lsissue}8446[8446], {lsissue}8333[8333], {lsissue}8163[8163], {lsissue}8103[8103], {lsissue}8087[8087], and {lsissue}7691[7691]).
There was a problem hiding this comment.
hahah you're right, I failed at being funny with added cost of reduced discovery. Will take your suggestion.
| *`Ruby`*: | ||
|
|
||
| * Fixed concurrency issues with multiple worker threads that was caused by a (https://github.com/jruby/jruby/issues/4868[JRuby issue]). | ||
| * Added file based Ruby script support as an alternative to the existing inline option (https://github.com/logstash-plugins/logstash-filter-ruby/pull/35[#35]). |
There was a problem hiding this comment.
Change to: file-based Ruby script
| * Fixed concurrency issues with multiple worker threads that was caused by a (https://github.com/jruby/jruby/issues/4868[JRuby issue]). | ||
| * Added file based Ruby script support as an alternative to the existing inline option (https://github.com/logstash-plugins/logstash-filter-ruby/pull/35[#35]). | ||
|
|
||
| ==== Output Plugins |
There was a problem hiding this comment.
Either add a [float] tag here or remove the one on line 20. The [float] changes the size of the font used by the heading. I personally think it looks better with the [float] tag, so I would add it here.
| obtained via the GeoIP2-ISP database. | ||
| [[logstash-6-1-0]] | ||
| === Logstash 6.1.0 Release Notes | ||
| * New experimental Java execution engine for Logstash pipelines. Off by default, it can be enabled with `--experimental-java-execution` ({lsissue}7950[Issue 7950]). |
There was a problem hiding this comment.
I'd start with a verb just to be consistent with other bullet points. Would also switch around the second sentence a bit and say:
Implemented a new experimental Java execution engine for Logstash pipelines. The Java engine is off by default, but can be enabled with --experimental-java-execution ({lsissue}7950[Issue 7950]).
(or you can start the sentence with "Created..." or "Added..." --dealer's choice.)
|
|
||
| *`Mutate`*: | ||
|
|
||
| * Added support for boolean to integer conversion (https://github.com/logstash-plugins/logstash-filter-mutate/pull/108[#108]). |
There was a problem hiding this comment.
Change to: boolean-to-integer (both ways are acceptable, but adding the hyphenation makes it easier to read, IMO)
|
|
||
| *`Elasticsearch`*: | ||
|
|
||
| * Ignore event's `type` field for the purpose of setting the document's `_type` when indexing to Elasticsearch 6.x or above (https://github.com/logstash-plugins/logstash-filter-elasticsearch/pull/712[#712]). |
There was a problem hiding this comment.
Would change to say:
When indexing to Elasticsearch 6.x or above, Logstash ignores the event's type field and no longer uses it to set the document's _type.
|
@dedemorton I've updated the content according to your remarks |
This list was compiled from https://github.com/elastic/logstash/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3Av6.1.0+is%3Aclosed+ and the plugin's changelogs bumped since 6.0.0/6.0.1