Merged
Conversation
Contributor
Author
|
Contributor
Author
|
This now checks for assets on s3 and is ready for review. To test it locally, comment line 20 and uncomment line 21.
|
Contributor
Author
|
@zcbenz we also want to verify that the debug symbols are uploaded to S3, but are not sure how to correlate the Electron version to the generated filenames on S3, e.g. |
Contributor
The only way I can think of is to download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check to ensure that a draft release has the right version, is a prerelease, has release notes, and includes all the expected assets.
The
prereleasenpm script will be run automatically whennpm run releaseis run.🍐 @vanessayuenn