Add support for MySQL/MariaDB#89
Conversation
|
I ran the tests locally and they passed. Someone needs tot trigger the CI so I can fix potential CI issues. |
84b531b to
3a328d3
Compare
|
Thanks for this PR @phihos! It looks great, I will take a deeper look later this week. Apparently GitHub Actions doesn't like the |
|
Hi, thanks for the feedback. I checked the health command and according to an official blogpost the command is correct. I also tried it myself and the script and its argument are accepted. I guess GH actions/docker does not like the single quotes very much. I replaced them with double quotes and added |
|
Fixed the formatting issue. Next run should at least go to the database tests. |
|
I forgot a line in the example test config which I put in my local test config. The tables should exist now. @crbelaus Can you trigger CI again? |
|
Sorry, I accidentally reverted the health-cmd fix. Should work again now. |
|
I also accidentally reverted the formatter fix from yesterday 🙈 |
|
Finally 🥳 |
odarriba
left a comment
There was a problem hiding this comment.
Looks good!! Thanks for this amazing contribution ❤️
|
Thank you for merging my PR. Now I do not have to maintain a fork for my use-case. Your code was already very well structured and implementation went smoothly. Looking forward to future releases :-) |
This PR adds support for the Exto adapter
Ecto.Adapters.MyXQL.Closes #85.