Skip to content

Allow for options to be customized#27

Merged
bryanjos merged 1 commit intoelixirscript:masterfrom
DCzajkowski:master
May 2, 2019
Merged

Allow for options to be customized#27
bryanjos merged 1 commit intoelixirscript:masterfrom
DCzajkowski:master

Conversation

@DCzajkowski
Copy link
Copy Markdown
Contributor

@DCzajkowski DCzajkowski commented May 1, 2019

Allow for options to be passed in as the second argument.

value |> generate() # still works
value |> generate(true) # default behavior
value |> generate(false) # still supported
value |> generate(%{"indent_level" => 2}) # "beauty" => true is inferred, but can be overridden

This PR does not introduce any breaking changes, but allows to customize the configuration.

@bryanjos bryanjos merged commit 91eb515 into elixirscript:master May 2, 2019
@bryanjos
Copy link
Copy Markdown
Collaborator

bryanjos commented May 2, 2019

Thanks!

@bryanjos
Copy link
Copy Markdown
Collaborator

bryanjos commented May 2, 2019

Published: https://hex.pm/packages/estree/2.7.0

@DCzajkowski
Copy link
Copy Markdown
Contributor Author

DCzajkowski commented May 2, 2019

Awesome 🎉

@dependabot-preview dependabot-preview bot mentioned this pull request May 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryanjos bryanjos bryanjos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DCzajkowski @bryanjos