Conversation
|
Hello, @workingjubilee! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
|
SourceLevel has finished reviewing this Pull Request and has found:
You can see more details about this review at https://app.sourcelevel.io/github/elixirscript/elixirscript/pulls/492. |
|
Thanks! As for travis, I think I'll dig in now and see what I can fix there. It's been a while since that was looked at and can be made better |
|
FYI I updated the travis file in master. Looks like 4 tests are currently failing but it at leasts updates the CI configuration. |
This PR addresses a few lints that were reported on https://app.sourcelevel.io/github/elixirscript/elixirscript and I can include more if desired.
All the tests for the files I updated pass. There are definitely broken tests in other parts of the app, apparently on the Elixir side. I would like to dig into those more and get to fixing, but I figured I'd start with some basic cleanup before commencing real work, and that this change is complete in itself.
Edit:
The command "wget -o ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}" failed and exited with 8 during .Why are you like this, Travis? What have I done to you?