feat: auto-disarm cloud alerts after firing#265
Merged
Conversation
Cloud availability alerts now automatically disarm after firing to prevent continuous notifications. Users can re-arm alerts at any time from the alert management page. Changes: - Add `is_armed` column to cloud_availability_alert (migration 0013) - Worker only fetches armed alerts and disarms them after firing - API supports re-arming via PATCH with isArmed: true - UI shows disarmed state with badge and re-arm button - Update descriptions to reflect new behavior Fixes #264 https://claude.ai/code/session_01KgBxH5WppN5k7houNonsf8
CI uses `lts/*` which now resolves to Node 24 (npm 11), but the lockfile was generated with Node 22 (npm 10). npm 11 has stricter peer dependency handling and rejects the lockfile. Pin all workflows to Node 22 (Maintenance LTS until Apr 2027) to match the development environment. https://claude.ai/code/session_01KgBxH5WppN5k7houNonsf8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_armedcolumn tocloud_availability_alerttable (migration 0013)WHERE is_armed = 1) and disarms them in the same batch as recording triggersPATCH /cloud-alerts/:idwith{ isArmed: true }Test plan
npm run checkpasses (0 errors, 0 warnings)npm run testpasses (33 tests)npm run lintpasses (0 errors)is_armedis_armed = TRUEhttps://claude.ai/code/session_01KgBxH5WppN5k7houNonsf8