Open
Conversation
anjali-deshpande-hub
approved these changes
Mar 24, 2026
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done!
One minor observation - The PR contains changes to assignment-1.ipynb as well. It should only contain updates to assignment_2.ipynb. For future assignments, please switch to the main branch before creating the assignment-2 branch, so that assignment-2 is branched from main rather than from assignment-1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I was adding the code for Assingment 2.
What did you learn from the changes you have made?
Nothing
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I think that the check_zeros() function was not necessary, it could be a 1 line step in the detect_problems() function
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
none
How were these changes tested?
I ran the code for multiple files.
A reference to a related issue in your repository (if applicable)
Checklist