Conversation
Member
Author
|
I tried applying the hunk below, but it doesn't seem to work as he intended. From eafd0478fe41bbc6211a42e8759a584caa436448 Mon Sep 17 00:00:00 2001
From: Stefan Monnier <[email protected]>
Date: Mon, 10 Apr 2023 21:14:00 +0900
Subject: [PATCH] Use `c-lang-const t` for c-lang-defconst
---
lisp/php-mode.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/php-mode.el b/lisp/php-mode.el
index df090088..1877a2cf 100644
--- a/lisp/php-mode.el
+++ b/lisp/php-mode.el
@@ -588,11 +588,11 @@ might be to handle switch and goto labels differently."
(c-lang-defconst c-basic-matchers-before
php (cl-remove-if (lambda (elm) (and (listp elm) (equal (car elm) "\\s|")))
- (c-lang-const c-basic-matchers-before php)))
+ (c-lang-const c-basic-matchers-before t)))
(c-lang-defconst c-basic-matchers-after
php (cl-remove-if (lambda (elm) (and (listp elm) (memq 'c-annotation-face elm)))
- (c-lang-const c-basic-matchers-after php)))
+ (c-lang-const c-basic-matchers-after t)))
(defconst php-mode--re-return-typed-closure
(eval-when-compile |
2d67ea1 to
9e952d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #737