Open
Conversation
anjali-deshpande-hub
suggested changes
May 12, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Its look good except for two issues:
- Changes to assignment-1.ipynb are also in the pull request. The PR should only include changes to assignment_2.ipynb. To check this, look at 'Files Changed' with the pull request. To fix this:
git checkout assignment-2
git checkout main -- assignment_1.ipynb
git add assignment_1.ipynb
git commit -m "Revert assignment_1.ipynb to the original version in main branch"
git push origin assignment-2
Make sure to run these commands in the correct directory.
- The function
detect_problemsshould not parse over all files inall_paths. It should only work on one file path and return true/false value based on analyzing that file. You can run detect_problems function inside a for loop if you like to check detect problems in all files in all_paths.
Kindly make the required changes. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added codes
What did you learn from the changes you have made?
For loop is important, def class and using it correctly is important, how to import a file and process information.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
on the relative and absolute file path, but it was cleared in the session
How were these changes tested?
tested in the vscode platform
A reference to a related issue in your repository (if applicable)
N/A
Checklist