Open
Conversation
kelichiu
reviewed
Feb 7, 2025
kelichiu
left a comment
There was a problem hiding this comment.
Total Points: 64/70
Section 1: 42/46
- Date table is missing its relationship with other tables (Sales, Order and Employee_Shifts)
- Order table is actually the orders to refill the book stock from suppliers, not the customer orders. Having relationship with Sales is not correctly.
Section 2: 6/8
- WINDOW FUNCTION Q1: When using row_number, the output data is not unique. We need to use GROUP BY to retrieve unique data by customer per date
Section 3: 8/8
Section 4: 8/8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code to answer assignment questions.
What did you learn from the changes you have made?
How to use windowed functions in SQL.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
NA
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The assignment was overall challenging than the first one since we learned to combine several different functions in one query. I reviewed lecture slides, live coding, and used online resources to help the assignment.
How were these changes tested?
On DB Browser for SQlite.
A reference to a related issue in your repository (if applicable)
NA
Checklist